[Lldb-commits] [PATCH] D12020: Print unexpected successes at the end of dosep.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 13 15:45:42 PDT 2015


zturner created this revision.
zturner added a reviewer: chaoren.
zturner added a subscriber: lldb-commits.

New output looks like this:

FAIL: LLDB (suite) :: TestThreadStepOut.py (Windows zturner-win81 8 6.2.9200 AMD64 Intel64 Family 6 Model 45 Stepping 7, GenuineIntel)
FAIL: LLDB (suite) :: TestValueAPI.py (Windows zturner-win81 8 6.2.9200 AMD64 Intel64 Family 6 Model 45 Stepping 7, GenuineIntel)
FAIL: LLDB (suite) :: TestValueMD5Crash.py (Windows zturner-win81 8 6.2.9200 AMD64 Intel64 Family 6 Model 45 Stepping 7, GenuineIntel)
FAIL: LLDB (suite) :: TestVectorTypesFormatting.py (Windows zturner-win81 8 6.2.9200 AMD64 Intel64 Family 6 Model 45 Stepping 7, GenuineIntel)
Unexpected Successes (1)
UNEXPECTED SUCCESS: LLDB (suite) :: TestSettings.py (Windows zturner-win81 8 6.2.9200 AMD64 Intel64 Family 6 Model 45 Stepping 7, GenuineIntel)
[50856 refs]
ninja: build stopped: subcommand failed.


It is not smart enough to dig into the individual file (TestSettings.py in this example) and find out which test passed that was not expected.  That can be done as future work if anyone is interested.  The important thing though is that unexpected successes currently have zero visibility, so it is hard to tell when a change fixes existing broken stuff.

The hope is that surfacing this will lead to more tests being re-enabled.

http://reviews.llvm.org/D12020

Files:
  test/dosep.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12020.32101.patch
Type: text/x-patch
Size: 5058 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150813/256d96ab/attachment.bin>


More information about the lldb-commits mailing list