[Lldb-commits] [PATCH] D11641: Handle floating point and aggregate return types in SysV-mips64 ABI
Bhushan Attarde
bhushan.attarde at imgtec.com
Tue Aug 4 00:40:07 PDT 2015
bhushan added inline comments.
================
Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:629-633
@@ +628,7 @@
+ // The result is in our data buffer. Create a variable object out of it
+ return_valobj_sp = ValueObjectConstResult::Create (&thread,
+ return_clang_type,
+ ConstString(""),
+ return_ext);
+
+ return return_valobj_sp;
----------------
jingham wrote:
> Looks fine in this diff. The mailed diff still looks a little funny. Can't tell if it is my mailer or if you are using tabs & expecting them to be 8 characters? If the former, this is fine, but make sure you always use spaces for indentation, not tabs.
I have verified this, the latest diff does not contain any tabs.
Repository:
rL LLVM
http://reviews.llvm.org/D11641
More information about the lldb-commits
mailing list