[Lldb-commits] [PATCH] D11641: Handle floating point and aggregate return types in SysV-mips64 ABI

Jim Ingham jingham at apple.com
Mon Aug 3 11:43:51 PDT 2015

jingham added a comment.

Looks fine.  The change at line 466 looks like it might have tabs rather than spaces in it, please check that.  Otherwise, it's okay.

Comment at: source/Plugins/ABI/SysV-mips64/ABISysV_mips64.cpp:629-633
@@ +628,7 @@
+                    // The result is in our data buffer.  Create a variable object out of it
+                    return_valobj_sp = ValueObjectConstResult::Create (&thread, 
+                                                                       return_clang_type,
+                                                                       ConstString(""),
+                                                                       return_ext);
+                    return return_valobj_sp;
Looks fine in this diff.  The mailed diff still looks a little funny.  Can't tell if it is my mailer or if you are using tabs & expecting them to be 8 characters?  If the former, this is fine, but make sure you always use spaces for indentation, not tabs.



More information about the lldb-commits mailing list