[Lldb-commits] [PATCH] D11127: [CMake] Don't build Interpreter unittest if python is disabled

Pavel Labath labath at google.com
Fri Jul 31 00:48:34 PDT 2015


On 30 July 2015 at 22:50, Zachary Turner <zturner at google.com> wrote:
> You might run into one remaining issue.  In HostPosix (or maybe HostLinux) it manually #includes "lldb-python.h" and there is 1 or 2 lines of code that that gets the python version using some #define from the python header files.  This is the last piece of the puzzle that I did not fix.
>
> The way to fix this is to update ScriptInterpreter base class to provide an abstract GetInterpreterVersion() method.  Have ScriptInterpreterPython override this to pull the value from the python header.  Then have HostLinux or HostPosix or whatever it is use the PluginManager to get the Plugin for eLanguagePython, and call the GetInterpreterVersion method.

I'll take a look into this when I get back in about two weeks, unless
someone beets me to it.

 Also, thanks for doing the python pluginization.

pl




More information about the lldb-commits mailing list