[Lldb-commits] [PATCH] D11127: [CMake] Don't build Interpreter unittest if python is disabled

Zachary Turner zturner at google.com
Thu Jul 30 14:50:37 PDT 2015


zturner added a comment.

You might run into one remaining issue.  In HostPosix (or maybe HostLinux) it manually #includes "lldb-python.h" and there is 1 or 2 lines of code that that gets the python version using some #define from the python header files.  This is the last piece of the puzzle that I did not fix.

The way to fix this is to update ScriptInterpreter base class to provide an abstract GetInterpreterVersion() method.  Have ScriptInterpreterPython override this to pull the value from the python header.  Then have HostLinux or HostPosix or whatever it is use the PluginManager to get the Plugin for eLanguagePython, and call the GetInterpreterVersion method.

I didn't fix this yet because my primary focus has been Windows, but AFAIK that's all that's necessary to remove the last implicit link dependency on Python.


Repository:
  rL LLVM

http://reviews.llvm.org/D11127







More information about the lldb-commits mailing list