[Lldb-commits] [lldb] r242262 - Fix another little nit with detach and keep stopped, you have to check

Jim Ingham jingham at apple.com
Tue Jul 14 17:59:25 PDT 2015


Author: jingham
Date: Tue Jul 14 19:59:25 2015
New Revision: 242262

URL: http://llvm.org/viewvc/llvm-project?rev=242262&view=rev
Log:
Fix another little nit with detach and keep stopped, you have to check
both for packet success and that the response is OK.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=242262&r1=242261&r2=242262&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Tue Jul 14 19:59:25 2015
@@ -2293,7 +2293,8 @@ GDBRemoteCommunicationClient::Detach (bo
             const int packet_len = ::snprintf(packet, sizeof(packet), "qSupportsDetachAndStayStopped:");
             assert (packet_len < (int)sizeof(packet));
             StringExtractorGDBRemote response;
-            if (SendPacketAndWaitForResponse (packet, packet_len, response, false) == PacketResult::Success)
+            if (SendPacketAndWaitForResponse (packet, packet_len, response, false) == PacketResult::Success
+                  && response.IsOKResponse())
             {
                 m_supports_detach_stay_stopped = eLazyBoolYes;        
             }





More information about the lldb-commits mailing list