[Lldb-commits] [lldb] r242256 - Correct length of packet that GDBRemoteCommunicationClient::Detach

Jason Molenda jmolenda at apple.com
Tue Jul 14 17:16:10 PDT 2015


Author: jmolenda
Date: Tue Jul 14 19:16:09 2015
New Revision: 242256

URL: http://llvm.org/viewvc/llvm-project?rev=242256&view=rev
Log:
Correct length of packet that GDBRemoteCommunicationClient::Detach 
should send when detaching and leaving the remote process/system
halted.  Previously only the 'D' initial char was sent, which
resumed the process like a normal detach.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=242256&r1=242255&r2=242256&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Tue Jul 14 19:16:09 2015
@@ -2311,7 +2311,7 @@ GDBRemoteCommunicationClient::Detach (bo
         else
         {
             StringExtractorGDBRemote response;
-            PacketResult packet_result = SendPacketAndWaitForResponse ("D1", 1, response, false);
+            PacketResult packet_result = SendPacketAndWaitForResponse ("D1", 2, response, false);
             if (packet_result != PacketResult::Success)
                 error.SetErrorString ("Sending extended disconnect packet failed.");
         }





More information about the lldb-commits mailing list