[Lldb-commits] [PATCH] D10954: [LLDB][MIPS] Added test case support for MIPS

[Nitesh Jain]

nitesh.jain added inline comments.

================
Comment at: test/python_api/value/change_values/TestChangeValueAPI.py:146-149
@@ -144,1 +145,6 @@
+        #To get invalid  address in case of MIPS Architecture when sp value is changed. 
+        if arch == "mips" or arch == "mips64" or arch == "mips32el" or arch == "mips64el":
+           result = sp_value.SetValueFromCString("100")
+        else:
+           result = sp_value.SetValueFromCString("1")
         self.assertTrue (result, "Setting sp returned true.")
----------------
clayborg wrote:
> clayborg wrote:
> > Can se just pick a safer SP value that would work on all systems? Maybe 32 or 64? Some systems might require SP to be aligned to a specific 4, 8 or 16 byte boundary and I am guessing that is what this change is trying to fix. Can we just change the SP value to 64?
> If we can change this to be 64 then we can remove the arch tests...
Even changing sp to 64 couldn't cause the test case to passed. Since it was generating SIGBUS signal with si_code=SI_KERENEL for invalid 64 bit address. which was not handle.

The Patch [ http://reviews.llvm.org/D11176 | To handle SI_KERENEL generated for invalid 64 bit address ] handle above mentioned case.


Repository:
  rL LLVM

http://reviews.llvm.org/D10954