[Lldb-commits] [lldb] r241522 - Make the "lldb/Utility/JSON.h" able to parse JSON into tokens with the new JSONParser class.

[Jason Molenda]

> On Jul 6, 2015, at 5:31 PM, Siva Chandra <sivachandra at google.com> wrote:
> 
> On Mon, Jul 6, 2015 at 4:40 PM, Greg Clayton <gclayton at apple.com> wrote:
>> Modified: lldb/trunk/include/lldb/Utility/JSON.h
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/JSON.h?rev=241522&r1=241521&r2=241522&view=diff
>> ==============================================================================
>> --- lldb/trunk/include/lldb/Utility/JSON.h (original)
>> +++ lldb/trunk/include/lldb/Utility/JSON.h Mon Jul  6 18:40:40 2015
>> @@ -11,6 +11,7 @@
>> #define utility_JSON_h_
>> 
>> #include "lldb/Core/Stream.h"
>> +#include "Utility/StringExtractor.h"
> 
> Should StringExtractor.h be moved to include/lldb/Utility? The build
> currently fails while compiling argdumper.cpp.


This happens to build cleanly on macosx, using the xcode build system.  Not sure if we're looking at a cmake vrs xcode build system difference or not.   Doesn't NativeProcessLinux.cpp do the same thing?

> 
>> Modified: lldb/trunk/source/Utility/JSON.cpp
> ...
>> +                            if (CHAR_MIN <= escaped_ch && escaped_ch <= CHAR_MAX)
> 
> I am also requiring to include limits.h explicitly to see definitions
> of CHAR_MIN and CHAR_MAX.

Something must be too permissive on macosx; we should add <limits.h> to this file.

J