[Lldb-commits] [lldb] r241522 - Make the "lldb/Utility/JSON.h" able to parse JSON into tokens with the new JSONParser class.

[Siva Chandra]

On Mon, Jul 6, 2015 at 4:40 PM, Greg Clayton <gclayton at apple.com> wrote:
> Modified: lldb/trunk/include/lldb/Utility/JSON.h
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/JSON.h?rev=241522&r1=241521&r2=241522&view=diff
> ==============================================================================
> --- lldb/trunk/include/lldb/Utility/JSON.h (original)
> +++ lldb/trunk/include/lldb/Utility/JSON.h Mon Jul  6 18:40:40 2015
> @@ -11,6 +11,7 @@
>  #define utility_JSON_h_
>
>  #include "lldb/Core/Stream.h"
> +#include "Utility/StringExtractor.h"

Should StringExtractor.h be moved to include/lldb/Utility? The build
currently fails while compiling argdumper.cpp.

> Modified: lldb/trunk/source/Utility/JSON.cpp
...
> +                            if (CHAR_MIN <= escaped_ch && escaped_ch <= CHAR_MAX)

I am also requiring to include limits.h explicitly to see definitions
of CHAR_MIN and CHAR_MAX.