[Lldb-commits] [PATCH] [NativeProcessLinux] Use lambdas in DoOperation calls

[Chaoren Lin]

LGTM.


================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:3178
@@ +3177,3 @@
+        Error error;
+        NativeProcessLinux::PtraceWrapper(PTRACE_CONT, tid, nullptr, (void*)data, 0, error);
+        return error;
----------------
labath wrote:
> chaoren wrote:
> > Does it make sense to have PtraceWrapper return Error? To be consistent with some changes you made above.
> I've thought about that as well and I think it is a good idea. I propose to do it in a followup patch. I'll need to check if putting the current return value in a by-ref parameter will not make other things more awkward.
I think it might be better to pass a pointer instead, for consistency with the other arguments, and makes it optional.

http://reviews.llvm.org/D10694

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/