[Lldb-commits] [PATCH] [NativeProcessLinux] Use lambdas in DoOperation calls

Tamas Berghammer tberghammer at google.com
Thu Jun 25 05:37:21 PDT 2015


================
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:259
@@ -258,3 +258,3 @@
                     ProcessPOSIXLog::DecNestLevel();
-                return bytes_read;
+                return error;
             }
----------------
labath wrote:
> tberghammer wrote:
> > (nit): You can do a "return Error();" here
> I don't think so. PtraceWrapper sets the error variable, and I need to test it. right?
Sorry, I missed that call

http://reviews.llvm.org/D10694

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list