[Lldb-commits] [PATCH] [ValueObjectPrinter::GetValueSummaryError] Get summary of non-synthetic values.

[Siva Chandra]

On Wed, Jun 24, 2015 at 10:46 AM, Enrico Granata <granata.enrico at gmail.com> wrote:

> I don't think this is the right change. A summary should be getting the most qualified

>  possible value - compatible with user settings - because it makes sense to use that extra

>  information in presenting information. Imagine a summary that wants to say

>  "I have %d elements". If we gave to it the non-synthetic value, it would compute the number

>  of elements in the underlying storage, not the count of user-visible values. That is the

>  wrong way to go at it.


I agree with "A summary should be getting the most qualified possible value" and per my understanding and experimenting with a few examples, this change does not affect it. All this change does is to make the backing ValueObject of the SBValue to be non-synthetic. The SBValue passed to the summary script will still exhibit the incarnation as dictated by the user settings.


http://reviews.llvm.org/D10624

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/