[Lldb-commits] [PATCH] [ValueObjectPrinter::GetValueSummaryError] Get summary of non-synthetic values.

[Enrico Granata]

I don't think this is the right change. A summary should be getting the most qualified possible value - compatible with user settings - because it makes sense to use that extra information in presenting information. Imagine a summary that wants to say "I have %d elements". If we gave to it the non-synthetic value, it would compute the number of elements in the underlying storage, not the count of user-visible values. That is the wrong way to go at it.

Of course, if a summary truly needs a specific flavor of value, it's fine to ask for that via the SBValue API.

I understand there is an underlying issue with SBValue::GetNonSyntheticValue() - and that is the one we should pursue. I am going to try and look at it today or tomorrow, but please do not commit this patch in the meanwhile.


http://reviews.llvm.org/D10624

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/