[Lldb-commits] [PATCH] Fix TestJoinAfterBreak test on Windows

Zachary Turner zturner at google.com
Mon Jun 1 14:01:03 PDT 2015


Do the multithreaded tests actually pass on Windows now after this, or do
they just get farther but fail on something else?

On Mon, Jun 1, 2015 at 1:48 PM Adrian McCarthy <amccarth at google.com> wrote:

> Hi zturner, jingham,
>
> 1.  Converted the inferior to use <thread> so that it can compile
> cross-platform
> 2.  Set a thread's state to eStateStopped when it's suspended.
> 3.  Don't set the resume state in WillResume.  That's just a hook for
> derived Thread classes to do bookkeeping.
> 4.  Adjust the expectations in the test to match reality.
>
> http://reviews.llvm.org/D10167
>
> Files:
>   source/Plugins/Process/Windows/TargetThreadWindows.cpp
>   test/functionalities/thread/break_after_join/Makefile
>   test/functionalities/thread/break_after_join/TestBreakAfterJoin.py
>   test/functionalities/thread/break_after_join/main.cpp
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150601/8ffd9a85/attachment.html>


More information about the lldb-commits mailing list