<div dir="ltr">Do the multithreaded tests actually pass on Windows now after this, or do they just get farther but fail on something else?<br></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jun 1, 2015 at 1:48 PM Adrian McCarthy <<a href="mailto:amccarth@google.com">amccarth@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi zturner, jingham,<br>
<br>
1.  Converted the inferior to use <thread> so that it can compile cross-platform<br>
2.  Set a thread's state to eStateStopped when it's suspended.<br>
3.  Don't set the resume state in WillResume.  That's just a hook for derived Thread classes to do bookkeeping.<br>
4.  Adjust the expectations in the test to match reality.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10167&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=YJE1sXI-zaAkBrR-JVdzBWncBixa4y3KkpbFUO3aZlc&s=8FN4mdXvmRr6iUwYPC-W9rppvkazjgW0UkYCHZtsLCo&e=" target="_blank">http://reviews.llvm.org/D10167</a><br>
<br>
Files:<br>
  source/Plugins/Process/Windows/TargetThreadWindows.cpp<br>
  test/functionalities/thread/break_after_join/Makefile<br>
  test/functionalities/thread/break_after_join/TestBreakAfterJoin.py<br>
  test/functionalities/thread/break_after_join/main.cpp<br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=YJE1sXI-zaAkBrR-JVdzBWncBixa4y3KkpbFUO3aZlc&s=akUAsPztzoE6DqsCdgN_RANAqKP0628yZ-ELhKZp5Tg&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div>