[Lldb-commits] [PATCH] Improve test for g++ 4.6

[Chaoren Lin]

But that would also match clan//g++//. Maybe we should check for gcc in
$(CC)?
On May 29, 2015 08:58, "Chaoren Lin" <chaorenl at google.com> wrote:

> ================
> Comment at: test/make/Makefile.rules:346
> @@ -345,1 +345,3 @@
> +ifneq "$(strip $(CXX_SOURCES) $(OBJCXX_SOURCES))" ""
>  ifneq (,$(filter g++,$(CXX)))
> +       CXXVERSION = $(shell $(CXX) -dumpversion | cut -b 1-3)
> ----------------
> I think we should use `findstring` instead of filter here, since `filter`
> can //only// match `g++` exactly and ignore things like
> `special-custom-g++` and `/path/to/g++`. Also, it's a little weird to have
> 2 ways of comparing empty strings, I think we should standardize on `ifneq
> "string 1" "string 2"`.
>
> http://reviews.llvm.org/D10122
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150529/c73751d8/attachment.html>