<p dir="ltr">But that would also match clan//g++//. Maybe we should check for gcc in $(CC)?</p>
<div class="gmail_quote">On May 29, 2015 08:58, "Chaoren Lin" <<a href="mailto:chaorenl@google.com">chaorenl@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: test/make/Makefile.rules:346<br>
@@ -345,1 +345,3 @@<br>
+ifneq "$(strip $(CXX_SOURCES) $(OBJCXX_SOURCES))" ""<br>
 ifneq (,$(filter g++,$(CXX)))<br>
+       CXXVERSION = $(shell $(CXX) -dumpversion | cut -b 1-3)<br>
----------------<br>
I think we should use `findstring` instead of filter here, since `filter` can //only// match `g++` exactly and ignore things like `special-custom-g++` and `/path/to/g++`. Also, it's a little weird to have 2 ways of comparing empty strings, I think we should standardize on `ifneq "string 1" "string 2"`.<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10122&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=-bOh3CnesnX6BSM4k3I016fF-wl74FtnPrp2y-PWTcs&s=K4merjyE8cMdutsweO-aieqo4QYsoRAlI0H-tVe5Q-0&e=" target="_blank">http://reviews.llvm.org/D10122</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=MEqT8U_n7oNfuDW5NRbY3ZV384ZquXIYFPWmprwUdKM&m=-bOh3CnesnX6BSM4k3I016fF-wl74FtnPrp2y-PWTcs&s=InedtftfYwgULh9H994_T4zxNl_VSPiXWDvqMlWQhsM&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div>