[Lldb-commits] [lldb] r237271 - Check the host platform to determine logging channel to test in TestRegisters.py

Robert Flack flackr at gmail.com
Wed May 13 11:23:10 PDT 2015


Author: flackr
Date: Wed May 13 13:23:10 2015
New Revision: 237271

URL: http://llvm.org/viewvc/llvm-project?rev=237271&view=rev
Log:
Check the host platform to determine logging channel to test in TestRegisters.py

Checks the host platform to determine logging channel to test in
TestRegisters.py as the logging runs host side.

Test Plan:
./dotest.py $DOTEST_OPTS -v -t -p TestRegisters.py
This passes mac -> linux as it's logging the correct channel.

Differential Revision: http://reviews.llvm.org/D9755

Modified:
    lldb/trunk/test/functionalities/register/TestRegisters.py

Modified: lldb/trunk/test/functionalities/register/TestRegisters.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/register/TestRegisters.py?rev=237271&r1=237270&r2=237271&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/register/TestRegisters.py (original)
+++ lldb/trunk/test/functionalities/register/TestRegisters.py Wed May 13 13:23:10 2015
@@ -88,14 +88,16 @@ class RegisterCommandsTestCase(TestBase)
 
     # platform specific logging of the specified category
     def log_enable(self, category):
+        # This intentionally checks the host platform rather than the target
+        # platform as logging is host side.
         self.platform = ""
-        if self.platformIsDarwin():
+        if sys.platform.startswith("darwin"):
             self.platform = "" # TODO: add support for "log enable darwin registers"
 
-        if self.getPlatform() == "freebsd":
+        if sys.platform.startswith("freebsd"):
             self.platform = "freebsd"
 
-        if self.getPlatform() == "linux":
+        if sys.platform.startswith("linux"):
             self.platform = "linux"
 
         if self.platform != "":





More information about the lldb-commits mailing list