[Lldb-commits] [lldb] r237270 - Enable workaround for finding functions in global namespace on linux binaries on

[Robert Flack]

Author: flackr
Date: Wed May 13 13:20:02 2015
New Revision: 237270

URL: http://llvm.org/viewvc/llvm-project?rev=237270&view=rev
Log:
Enable workaround for finding functions in global namespace on linux binaries on
all hosts.

We require a workaround to be able to locate global and anonymous namespace
functions in the dwarf symbols on linux binaries. This patch enables this code
on all platforms so that we can still find these symbols when debugging from a
different host platform.

Test Plan:
The following tests begin passing when running with a mac host to linux client:
TestCallCPPFunction.py
TestCallStopAndContinue.py
TestExprs.py
TestExprsChar.py
TestNamespace.py
TestOverloadedFunctions.py
TestRvalueReferences.py
TestThreadExit.py

Differential Revision: http://reviews.llvm.org/D9754

Modified:
    lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=237270&r1=237269&r2=237270&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Wed May 13 13:20:02 2015
@@ -4033,8 +4033,7 @@ SymbolFileDWARF::FindFunctions (const Co
             FindFunctions (name, m_function_fullname_index, include_inlines, sc_list);
 
             // FIXME Temporary workaround for global/anonymous namespace
-            // functions on FreeBSD and Linux
-#if defined (__FreeBSD__) || defined (__linux__)
+            // functions debugging FreeBSD and Linux binaries.
             // If we didn't find any functions in the global namespace try
             // looking in the basename index but ignore any returned
             // functions that have a namespace (ie. mangled names starting with 
@@ -4061,7 +4060,6 @@ SymbolFileDWARF::FindFunctions (const Co
                     }
                 }
             }
-#endif
         }
         DIEArray die_offsets;
         DWARFCompileUnit *dwarf_cu = NULL;