[Lldb-commits] [lldb] r234821 - [TestPluginCommands] Add skipIfGcc at the right place.

Siva Chandra sivachandra at google.com
Mon Apr 13 17:13:29 PDT 2015

Author: sivachandra
Date: Mon Apr 13 19:13:28 2015
New Revision: 234821

URL: http://llvm.org/viewvc/llvm-project?rev=234821&view=rev
[TestPluginCommands] Add skipIfGcc at the right place.

The decorator @expectedFailureGcc was at the wrong place skipping this
test all together. This patch removes it and adds skipIfGcc at the right

Test Plan: dotest.py -C <gcc|clang> -p TestPluginCommands

Reviewers: chying, chaoren

Reviewed By: chaoren

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D9010


Modified: lldb/trunk/test/functionalities/plugins/commands/TestPluginCommands.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/plugins/commands/TestPluginCommands.py?rev=234821&r1=234820&r2=234821&view=diff
--- lldb/trunk/test/functionalities/plugins/commands/TestPluginCommands.py (original)
+++ lldb/trunk/test/functionalities/plugins/commands/TestPluginCommands.py Mon Apr 13 19:13:28 2015
@@ -9,7 +9,6 @@ import lldb
 from lldbtest import *
 import lldbutil
- at expectedFailureGcc #xfail to get buildbot green, test failed with gcc4.8.2
 class PluginCommandTestCase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
@@ -22,6 +21,7 @@ class PluginCommandTestCase(TestBase):
     @skipIfi386 # This test links against liblldb.so. Thus, the test requires a 32-bit liblldb.so.
+    @skipIfGcc # llvm.org/pr23221
     def test_load_plugin(self):
         """Test that plugins that load commands work correctly."""

More information about the lldb-commits mailing list