[Lldb-commits] [PATCH] Enabled a bunch of tests on Linux

Siva Chandra sivachandra at google.com
Fri Mar 27 15:37:30 PDT 2015


LGTM.
Couple of inline notes.

I was auditing the tests in http://reviews.llvm.org/D6910. Since you have already done, I am going to abandon that patch.


================
Comment at: test/functionalities/dynamic_value_child_count/TestDynamicValueChildCount.py:24
@@ -23,3 +23,3 @@
 
-    @expectedFailureLinux # FIXME: This needs to be root-caused.  It looks like the DWARF info is anticipating the derived class assignment.
+    @expectedFailureLinux("llvm.org/pr23039")
     @expectedFailureFreeBSD("llvm.org/pr19311") # continue at a breakpoint does not work
----------------
This is failing because of a completely different issue. If you replace the "continue" commands with "next", this test passes. I was digging into this exact test when I saw your patch.

================
Comment at: test/python_api/thread/TestThreadAPI.py:78
@@ -77,3 +77,3 @@
     @expectedFailureFreeBSD # llvm.org/pr20476
-    @expectedFailureLinux # llvm.org/pr14416
+    @expectedFailureLinux # need to 'thread step-out' twice to get out of malloc
     @python_api_test
----------------
May be a PR for this as well?

http://reviews.llvm.org/D8676

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list