[Lldb-commits] [PATCH] TestPrintStackTraces - made XFAIL more precise

[Vince Harron]

Hi clayborg, sivachandra,

Works with x86_64 inferior, fails w/i386 inferior - updated test to reflect

http://reviews.llvm.org/D8677

Files:
  test/python_api/lldbutil/process/TestPrintStackTraces.py

Index: test/python_api/lldbutil/process/TestPrintStackTraces.py
===================================================================
--- test/python_api/lldbutil/process/TestPrintStackTraces.py
+++ test/python_api/lldbutil/process/TestPrintStackTraces.py
@@ -18,15 +18,21 @@
         # Find the line number to break inside main().
         self.line = line_number('main.cpp', '// Set break point at this line.')
 
-    @expectedFailureLinux # llvm.org/pr15415 -- partial stack trace in thread 1 (while stopped inside a read() call)
+    # llvm.org/pr23043 - leaving the next two lines in so it's easy to find this 
+    # test will appear when searching for expectedFailure(Linux|i386)
+    #@expectedFailureLinux
+    #@expectedFailurei386
     @python_api_test
     def test_stack_traces(self):
         """Test SBprocess and SBThread APIs with printing of the stack traces."""
         self.buildDefault()
         self.break_and_print_stacktraces()
 
     def break_and_print_stacktraces(self):
         """Break at main.cpp:68 and do a threads dump"""
+        if self.getArchitecture() in ['i386'] and "linux" in sys.platform:
+            self.skipTest("Skipping because this test is known to fail on i386 Linux")
+
         exe = os.path.join(os.getcwd(), "a.out")
 
         target = self.dbg.CreateTarget(exe)

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8677.22829.patch
Type: text/x-patch
Size: 1319 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150327/dcf24338/attachment.bin>