[Lldb-commits] [lldb] r232805 - Fix ninja check-lldb

[Zachary Turner]

We could also update the CMake to allow specifying some CMake variables to
control the compiler and architecture information used to run tests.  This
way you could still use ninja check-lldb without requiring an update of the
buildbot scripts.

On Fri, Mar 20, 2015 at 11:20 AM Ying Chen <chying at google.com> wrote:

> Thank you Pavel for the quick fix! I will update Ninja on the bot.
>
> For your information, we've added lldb-test to run with
> clang3.5/gcc4.8/clangtot as compiler and i386/x86_64 as target architecture
> respectively(6 tests in total for each build). And this CL is pending on
> build bot master reconfiguration to take effect.
> Upon the new change, it won't call "ninja" to run test. Will call "dosep"
> directly to be able to pass in compiler and architecture information.
>
> Thanks,
> Ying
>
> On Fri, Mar 20, 2015 at 9:24 AM, Nico Weber <thakis at google.com> wrote:
>
>> On Fri, Mar 20, 2015 at 9:21 AM, Pavel Labath <labath at google.com> wrote:
>>
>>> +ying
>>>
>>> Thanks for the quick response.
>>>
>>> The bot is running ubuntu 14.04, which has ninja 1.3.4 as stable.
>>>
>>> Ying, I have worked around this issue for now, but for the future, would
>>> it be possible to update the ninja on the bot to something more recent
>>> (possibly by just downloading and building it from source).
>>>
>>
>> (There are prebuilt binaries at https://github.com/martine/ninja/releases
>> too)
>>
>>
>>> Incidentally, this breakage has caused an expression evaluation problem (
>>> http://reviews.llvm.org/D8482) to creep in unnoticed.
>>>
>>> cheers,
>>> pl
>>>
>>>
>>> On 20 March 2015 at 16:12, Nico Weber <thakis at google.com> wrote:
>>>
>>>> Your bot is likely running a very old version of ninja.
>>>>
>>>> On Fri, Mar 20, 2015 at 8:35 AM, Pavel Labath <labath at google.com>
>>>> wrote:
>>>>
>>>>> FWIW, I have filed a bug here <
>>>>> https://github.com/martine/ninja/issues/941>. It also contains a
>>>>> small test which demonstrates this behavior.
>>>>>
>>>>> On 20 March 2015 at 15:28, Zachary Turner <zturner at google.com> wrote:
>>>>>
>>>>>> +thakis
>>>>>>
>>>>>> On Fri, Mar 20, 2015 at 4:28 AM Pavel Labath <labath at google.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Author: labath
>>>>>>> Date: Fri Mar 20 06:24:36 2015
>>>>>>> New Revision: 232805
>>>>>>>
>>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=232805&view=rev
>>>>>>> Log:
>>>>>>> Fix ninja check-lldb
>>>>>>>
>>>>>>> Ninja apparently has issues with commands writing nul characters
>>>>>>> '\0' to stdout. When it
>>>>>>> encounters a nul character, the rest of the output is skipped (I
>>>>>>> will file a bug with ninja about
>>>>>>> that). This breaks the linux buildbot since it parses the ninja
>>>>>>> check-lldb output to get a list
>>>>>>> of failures.
>>>>>>>
>>>>>>> Recently, we have started outputting nul characters in lldb-server
>>>>>>> tests. This is probably
>>>>>>> a bug in itself, but I am not addressing that now. This is just a
>>>>>>> workaround commit, which
>>>>>>> prevents the nul characters from appearing in the output, and gets
>>>>>>> the buildbot operational again.
>>>>>>>
>>>>>>> Modified:
>>>>>>>     lldb/trunk/test/tools/lldb-server/socket_packet_pump.py
>>>>>>>
>>>>>>> Modified: lldb/trunk/test/tools/lldb-server/socket_packet_pump.py
>>>>>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/
>>>>>>> lldb-server/socket_packet_pump.py?rev=232805&r1=232804&
>>>>>>> r2=232805&view=diff
>>>>>>> ============================================================
>>>>>>> ==================
>>>>>>> --- lldb/trunk/test/tools/lldb-server/socket_packet_pump.py
>>>>>>> (original)
>>>>>>> +++ lldb/trunk/test/tools/lldb-server/socket_packet_pump.py Fri Mar
>>>>>>> 20 06:24:36 2015
>>>>>>> @@ -3,6 +3,7 @@ import re
>>>>>>>  import select
>>>>>>>  import threading
>>>>>>>  import traceback
>>>>>>> +import codecs
>>>>>>>
>>>>>>>  def _handle_output_packet_string(packet_contents):
>>>>>>>      if (not packet_contents) or (len(packet_contents) < 1):
>>>>>>> @@ -16,7 +17,7 @@ def _handle_output_packet_string(packet_
>>>>>>>
>>>>>>>  def _dump_queue(the_queue):
>>>>>>>      while not the_queue.empty():
>>>>>>> -        print the_queue.get(True)
>>>>>>> +        print codecs.encode(the_queue.get(True), "string_escape")
>>>>>>>          print "\n"
>>>>>>>
>>>>>>>  class SocketPacketPump(object):
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> lldb-commits mailing list
>>>>>>> lldb-commits at cs.uiuc.edu
>>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150320/4a2eab55/attachment.html>