<div dir="ltr">We could also update the CMake to allow specifying some CMake variables to control the compiler and architecture information used to run tests. This way you could still use ninja check-lldb without requiring an update of the buildbot scripts.<br></div><br><div class="gmail_quote">On Fri, Mar 20, 2015 at 11:20 AM Ying Chen <<a href="mailto:chying@google.com">chying@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thank you Pavel for the quick fix! I will update Ninja on the bot.<div><br></div><div>For your information, we've added lldb-test to run with clang3.5/gcc4.8/clangtot as compiler and i386/x86_64 as target architecture respectively(6 tests in total for each build). And this CL is pending on build bot master reconfiguration to take effect.</div><div>Upon the new change, it won't call "ninja" to run test. Will call "dosep" directly to be able to pass in compiler and architecture information. </div><div><br></div><div>Thanks,</div><div>Ying</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 20, 2015 at 9:24 AM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@google.com" target="_blank">thakis@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Fri, Mar 20, 2015 at 9:21 AM, Pavel Labath <span dir="ltr"><<a href="mailto:labath@google.com" target="_blank">labath@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>+ying<br></div><div><br></div><div>Thanks for the quick response.</div><div><br></div><div>The bot is running ubuntu 14.04, which has ninja 1.3.4 as stable.</div><div><br></div><div>Ying, I have worked around this issue for now, but for the future, would it be possible to update the ninja on the bot to something more recent (possibly by just downloading and building it from source).</div></div></blockquote><div><br></div></span><div>(There are prebuilt binaries at <a href="https://github.com/martine/ninja/releases" target="_blank">https://github.com/martine/ninja/releases</a> too)</div><div><div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div>Incidentally, this breakage has caused an expression evaluation problem (<a href="http://reviews.llvm.org/D8482" target="_blank">http://reviews.llvm.org/D8482</a>) to creep in unnoticed.<br></div><div><br></div><div>cheers,</div><div>pl</div><div><br></div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On 20 March 2015 at 16:12, Nico Weber <span dir="ltr"><<a href="mailto:thakis@google.com" target="_blank">thakis@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Your bot is likely running a very old version of ninja.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 20, 2015 at 8:35 AM, Pavel Labath <span dir="ltr"><<a href="mailto:labath@google.com" target="_blank">labath@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">FWIW, I have filed a bug here <<a href="https://github.com/martine/ninja/issues/941" target="_blank">https://github.com/martine/ninja/issues/941</a>>. It also contains a small test which demonstrates this behavior.</div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On 20 March 2015 at 15:28, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">+thakis<div><div><br><div class="gmail_quote">On Fri, Mar 20, 2015 at 4:28 AM Pavel Labath <<a href="mailto:labath@google.com" target="_blank">labath@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: labath<br>
Date: Fri Mar 20 06:24:36 2015<br>
New Revision: 232805<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=232805&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=232805&view=rev</a><br>
Log:<br>
Fix ninja check-lldb<br>
<br>
Ninja apparently has issues with commands writing nul characters '\0' to stdout. When it<br>
encounters a nul character, the rest of the output is skipped (I will file a bug with ninja about<br>
that). This breaks the linux buildbot since it parses the ninja check-lldb output to get a list<br>
of failures.<br>
<br>
Recently, we have started outputting nul characters in lldb-server tests. This is probably<br>
a bug in itself, but I am not addressing that now. This is just a workaround commit, which<br>
prevents the nul characters from appearing in the output, and gets the buildbot operational again.<br>
<br>
Modified:<br>
lldb/trunk/test/tools/lldb-<u></u>server/socket_packet_pump.py<br>
<br>
Modified: lldb/trunk/test/tools/lldb-<u></u>server/socket_packet_pump.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lldb/trunk/test/tools/lldb-server/socket_packet_pump.py?rev=232805&r1=232804&r2=232805&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lldb/trunk/test/tools/<u></u>lldb-server/socket_packet_<u></u>pump.py?rev=232805&r1=232804&<u></u>r2=232805&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- lldb/trunk/test/tools/lldb-<u></u>server/socket_packet_pump.py (original)<br>
+++ lldb/trunk/test/tools/lldb-<u></u>server/socket_packet_pump.py Fri Mar 20 06:24:36 2015<br>
@@ -3,6 +3,7 @@ import re<br>
import select<br>
import threading<br>
import traceback<br>
+import codecs<br>
<br>
def _handle_output_packet_string(<u></u>packet_contents):<br>
if (not packet_contents) or (len(packet_contents) < 1):<br>
@@ -16,7 +17,7 @@ def _handle_output_packet_string(<u></u>packet_<br>
<br>
def _dump_queue(the_queue):<br>
while not the_queue.empty():<br>
- print the_queue.get(True)<br>
+ print codecs.encode(the_queue.get(<u></u>True), "string_escape")<br>
print "\n"<br>
<br>
class SocketPacketPump(object):<br>
<br>
<br>
______________________________<u></u>_________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/lldb-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>
</blockquote></div>