[Lldb-commits] [PATCH] Move full initialization to lldb/API

[Zachary Turner]

What Tamas said.  I can hold it if there's a good reason, but I don't think
there's much risk involved here.  The actual initialization / shutdown code
is a straight copy/paste from what it was before.  So the question is just
if it's calling the initialization and shutdown code correctly.  And the
local linux test suite would catch that if it were an issue.

On Fri, Mar 20, 2015 at 8:15 AM Tamas Berghammer <tberghammer at google.com>
wrote:

> I think this CL won't effect remote Linux in any different way then local
> Linux so I don't see any reason why should we hold it back. We do several
> other change every week  what can have major effect on remote Linux without
> having a build bot and we haven't seen too much issue because of it. Also
> holding back this CL for several weeks can cause merge conflicts where I
> think the chance to make a mistake when resolving them would be higher then
> the risk of this change. I also think that this is just 1 step from a
> longer process of cleaning up the dependencies in lldb. Blocking that
> process for a longer time seems like a very bad idea for me.
>
>
> http://reviews.llvm.org/D8462
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150320/fa0aaac0/attachment.html>