[Lldb-commits] [PATCH] Fix for aarch64 lldb-server native builds

[Renato Golin]

In http://reviews.llvm.org/D8447#143614, @omjavaid wrote:

> Tamas:
>  There is no new variable being introduced and even if you supply
>  -DLLVM_HOST_TRIPLE from commandline this config file will still
>  encounter the bug.


This probably means that the LLDB CMake file is not well integrated. I don't know how much LLDB needs to be compiled inside LLVM, but that seems to be the standard for everything else. Does anyone know how to use the CMake modules on other projects?

> ===> And here we are forcing the triple to x86_64-linux-gnu in case we

>  encounter a 64bit target which is wrong.


Yes, this is completely wrong. But instead of guessing, we should be using what LLVM does. AFAIK, LLVM uses that GetHostTriple module to guess the triple, and later on, it uses that if the user hasn't specified in the command line. We should do the exact same thing on all projects, including LLDB.

But unfortunately, like you, I know very little of CMake and how it's used in other projects... :(

I'm hoping someone around could give us a hand.

cheers,
--renato


http://reviews.llvm.org/D8447

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/