[Lldb-commits] [PATCH] Fix for aarch64 lldb-server native builds

[Muhammad Omair Javaid]

Tamas:
There is no new variable being introduced and even if you supply
-DLLVM_HOST_TRIPLE from commandline this config file will still
encounter the bug.

Renato:
My knowledge of LLVM source is limited so I have tried to make the
hack that was already there in the LLDBConfig.cmake more usable. I ll
try if I can get the host triple using the function you have
mentioned.

Currently it looks something like this:

if (NOT LLDB_DISABLE_PYTHON)

  if(UNIX)

> we are bound to come here on any UNIX/Linux system
----------------------------------------------------

1. This is necessary for crosscompile on Ubuntu 14.04 64bit. Need a

proper fix.

  if(CMAKE_SIZEOF_VOID_P EQUAL 8)

> And here we are forcing the triple to x86_64-linux-gnu in case we
-------------------------------------------------------------------

encounter a 64bit target which is wrong.

      set(CMAKE_LIBRARY_ARCHITECTURE "x86_64-linux-gnu")
    endif()
  endif()
  if (MSVC)
    if ("${PYTHON_INCLUDE_DIR}" STREQUAL "" OR "${PYTHON_LIBRARY}" STREQUAL "")
      message("-- LLDB Embedded python disabled.  Embedding python on

Windows requires "

              "manually specifying PYTHON_INCLUDE_DIR *and* PYTHON_LIBRARY")
      set(LLDB_DISABLE_PYTHON 1)
    else()
      message("-- Found PythonLibs: ${PYTHON_LIBRARY}")
      include_directories(${PYTHON_INCLUDE_DIR})
    endif()
  else()
    find_package(PythonLibs REQUIRED)
    include_directories(${PYTHON_INCLUDE_DIRS})
  endif()

endif()


http://reviews.llvm.org/D8447

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/