[Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)

Ilia K ki.stfu at gmail.com
Wed Mar 18 01:04:30 PDT 2015


Remove unused IDS_PROCESS_SIGNAL_RECEIVED from CMICmnResources


http://reviews.llvm.org/D8256

Files:
  tools/lldb-mi/MICmnResources.cpp
  tools/lldb-mi/MICmnResources.h
  tools/lldb-mi/MIDriverMain.cpp

Index: tools/lldb-mi/MICmnResources.cpp
===================================================================
--- tools/lldb-mi/MICmnResources.cpp
+++ tools/lldb-mi/MICmnResources.cpp
@@ -91,7 +91,6 @@
     {IDS_CMDFACTORY_ERR_CMD_ALREADY_REGED, "Command factory. Command '%s' by that name already registered"},
     {IDS_CMDMGR_ERR_CMD_FAILED_CREATE, "Command manager. Command creation failed. %s"},
     {IDS_CMDMGR_ERR_CMD_INVOKER, "Command manager. %s "},
-    {IDS_PROCESS_SIGNAL_RECEIVED, "Process signal. Application received signal '%s' (%d)"},
     {IDS_MI_INIT_ERR_LOG, "Log. Error occurred during initialisation %s"},
     {IDS_MI_INIT_ERR_RESOURCES, "Resources. Error occurred during initialisation %s"},
     {IDS_MI_INIT_ERR_INIT, "Driver. Error occurred during initialisation %s"},
Index: tools/lldb-mi/MICmnResources.h
===================================================================
--- tools/lldb-mi/MICmnResources.h
+++ tools/lldb-mi/MICmnResources.h
@@ -104,8 +104,6 @@
     IDS_CMDMGR_ERR_CMD_FAILED_CREATE,
     IDS_CMDMGR_ERR_CMD_INVOKER,
 
-    IDS_PROCESS_SIGNAL_RECEIVED,
-
     IDS_MI_INIT_ERR_LOG,
     IDS_MI_INIT_ERR_RESOURCES,
     IDS_MI_INIT_ERR_INIT,
Index: tools/lldb-mi/MIDriverMain.cpp
===================================================================
--- tools/lldb-mi/MIDriverMain.cpp
+++ tools/lldb-mi/MIDriverMain.cpp
@@ -39,7 +39,6 @@
 #include "MICmnResources.h"
 #include "MICmnStreamStdin.h"
 #include "MIUtilDebug.h"
-#include "MICmnLog.h"
 
 #if MICONFIG_COMPILE_MIDRIVER_VERSION
 
@@ -74,8 +73,6 @@
             rDriverMgr.DriverResizeWindow((uint32_t)window_size.ws_col);
         }
     }
-
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGWINCH", vSigno));
 }
 
 // CODETAG_IOR_SIGNALS
@@ -109,8 +106,6 @@
         }
     }
 
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGINT", vSigno));
-
     // Send signal to driver so that it can take suitable action
     rDriverMgr.DeliverSignal (vSigno);
 }
@@ -141,8 +136,6 @@
         pDebugger->SaveInputTerminalState();
     }
 
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGTSTP", vSigno));
-
     // Send signal to driver so that it can take suitable action
     rDriverMgr.DeliverSignal (vSigno);
 }
@@ -172,8 +165,6 @@
         pDebugger->RestoreInputTerminalState();
     }
 
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGCONT", vSigno));
-
     // Send signal to driver so that it can take suitable action
     rDriverMgr.DeliverSignal (vSigno);
 }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8256.22163.patch
Type: text/x-patch
Size: 2663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150318/7385d0d1/attachment.bin>


More information about the lldb-commits mailing list