[Lldb-commits] [PATCH] Fix memory allocating inside signal handler (MI)

Ilia K ki.stfu at gmail.com
Wed Mar 18 00:40:06 PDT 2015


Revert CMICmnResources; Remove logging from signal handlers


http://reviews.llvm.org/D8256

Files:
  tools/lldb-mi/MIDriverMain.cpp

Index: tools/lldb-mi/MIDriverMain.cpp
===================================================================
--- tools/lldb-mi/MIDriverMain.cpp
+++ tools/lldb-mi/MIDriverMain.cpp
@@ -39,7 +39,6 @@
 #include "MICmnResources.h"
 #include "MICmnStreamStdin.h"
 #include "MIUtilDebug.h"
-#include "MICmnLog.h"
 
 #if MICONFIG_COMPILE_MIDRIVER_VERSION
 
@@ -74,8 +73,6 @@
             rDriverMgr.DriverResizeWindow((uint32_t)window_size.ws_col);
         }
     }
-
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGWINCH", vSigno));
 }
 
 // CODETAG_IOR_SIGNALS
@@ -109,8 +106,6 @@
         }
     }
 
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGINT", vSigno));
-
     // Send signal to driver so that it can take suitable action
     rDriverMgr.DeliverSignal (vSigno);
 }
@@ -141,8 +136,6 @@
         pDebugger->SaveInputTerminalState();
     }
 
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGTSTP", vSigno));
-
     // Send signal to driver so that it can take suitable action
     rDriverMgr.DeliverSignal (vSigno);
 }
@@ -172,8 +165,6 @@
         pDebugger->RestoreInputTerminalState();
     }
 
-    CMICmnLog::Instance().WriteLog(CMIUtilString::Format(MIRSRC(IDS_PROCESS_SIGNAL_RECEIVED), "SIGCONT", vSigno));
-
     // Send signal to driver so that it can take suitable action
     rDriverMgr.DeliverSignal (vSigno);
 }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8256.22161.patch
Type: text/x-patch
Size: 1477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150318/56dc3758/attachment.bin>


More information about the lldb-commits mailing list