[Lldb-commits] [PATCH] Add lldb-mi/lldb-server test folders to PATH before in dotest.py

Ilia K ki.stfu at gmail.com
Wed Mar 11 05:14:36 PDT 2015


================
Comment at: test/dotest.py:933
@@ -932,3 +932,3 @@
 
     pluginPath = os.path.join(scriptPath, 'plugins')
     pexpectPath = os.path.join(scriptPath, 'pexpect-2.4')
----------------
vharron wrote:
> Maybe scriptPath should be renamed to lldbTestRoot, this would improve understanding
> 
I think we should leave it as is, because scriptPath can be taken from env variable DOTEST_SCRIPT_DIR (see line 910).

If we do it, it will be strange why
```
lldbTestRoot = os.environ["DOTEST_SCRIPT_DIR"]
```

http://reviews.llvm.org/D8207

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list