[Lldb-commits] [PATCH] Add lldb-mi/lldb-server test folders to PATH before in dotest.py

Vince Harron vharron at google.com
Tue Mar 10 17:25:14 PDT 2015


Can you make the requested changes?


================
Comment at: test/dotest.py:933
@@ -932,3 +932,3 @@
 
     pluginPath = os.path.join(scriptPath, 'plugins')
     pexpectPath = os.path.join(scriptPath, 'pexpect-2.4')
----------------
Maybe scriptPath should be renamed to lldbTestRoot, this would improve understanding


================
Comment at: test/dotest.py:945
@@ -942,1 +944,3 @@
     sys.path.append(pluginPath)
+    sys.path.append(toolsLldbMiPath)
+    sys.path.append(toolsLldbServerPath)
----------------
Comment: Adding test/tools/lldb-mi to the path makes it easy to "import lldbmi_testcase" from the Mi tests


================
Comment at: test/dotest.py:946
@@ -943,1 +945,3 @@
+    sys.path.append(toolsLldbMiPath)
+    sys.path.append(toolsLldbServerPath)
 
----------------
Comment: Adding test/tools/lldb-server to the path makes it easy to "import lldbgdbserverutils" from the lldb-server tests

http://reviews.llvm.org/D8207

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list