[Lldb-commits] [PATCH] expose 64 bit breakpoint addresses through MI

[Zachary Turner]

Ahh, sorry.  It seems I was the one that was confused then.  Sorry for the
noise.

On Tue, Mar 10, 2015 at 5:03 PM Chuck Ries <Chuck.Ries at microsoft.com> wrote:

>  I’m a little confused. This patch is for a separate issue; it’s a
> separate commit. Should it be attached to the review for the other commit?
>
>
>
> *From:* Zachary Turner [mailto:zturner at google.com]
> *Sent:* Tuesday, March 10, 2015 4:53 PM
> *To:* reviews+D8238+public+d4d2ef3693b3ed2b at reviews.llvm.org; Chuck Ries;
> abidh.haq at gmail.com
> *Cc:* lldb-commits at cs.uiuc.edu
> *Subject:* Re: [Lldb-commits] [PATCH] expose 64 bit breakpoint addresses
> through MI
>
>
>
> Hi Chuck, can you resubmit this patch attached to the other review?  The
> workflow isn't entirely obvious, but there's a couple of things you need to
> do different.
>
>
>
> 1) When you create the diff with the suggested changes, create the diff
> against origin (or whatever you created the *original* patch against), not
> against the first version of the patch.  So if HEAD is the first version of
> the patch you uploaded, create your diff against HEAD~1.  You want the new
> patch to contain the changes _plus_ the original patch.
>
>
>
> 2) When you attach the patch to Phabricator, you'll get a combo box and
> the default value is "Create new revision".  Change this to "Attach to
> existing revision" and then choose the entry for the first patch you
> uploaded.
>
>
>
> On Tue, Mar 10, 2015 at 4:49 PM Chuck Ries <chuckr at microsoft.com> wrote:
>
> Hi abidh,
>
> http://reviews.llvm.org/D8238
>
> Files:
>   tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
>   tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
>
> Index: tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
> ===================================================================
> --- tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
> +++ tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
> @@ -1048,7 +1048,7 @@
>  bool
>  CMICmnLLDBDebugSessionInfo::MIResponseFormBrkPtFrameInfo(const SBrkPtInfo
> &vrBrkPtInfo, CMICmnMIValueTuple &vwrMiValueTuple)
>  {
> -    const CMIUtilString strAddr(CMIUtilString::Format("0x%08llx",
> vrBrkPtInfo.m_pc));
> +    const CMIUtilString strAddr(CMIUtilString::Format("0x%016llx",
> vrBrkPtInfo.m_pc));
>      const CMICmnMIValueConst miValueConst2(strAddr);
>      const CMICmnMIValueResult miValueResult2("addr", miValueConst2);
>      if (!vwrMiValueTuple.Add(miValueResult2))
> Index: tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
> ===================================================================
> --- tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
> +++ tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
> @@ -87,7 +87,7 @@
>          CMIUtilString m_strType;        // Break point type.
>          bool m_bDisp;                   // True = "del", false = "keep".
>          bool m_bEnabled;                // True = enabled, false =
> disabled break point.
> -        MIuint m_pc;                    // Address number.
> +        MIuint64 m_pc;                  // Address number.
>          CMIUtilString m_fnName;         // Function name.
>          CMIUtilString m_fileName;       // File name text.
>          CMIUtilString m_path;           // Full file name and path text.
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150311/6c3838d7/attachment.html>