<div dir="ltr">Ahh, sorry. It seems I was the one that was confused then. Sorry for the noise.<br></div><br><div class="gmail_quote">On Tue, Mar 10, 2015 at 5:03 PM Chuck Ries <<a href="mailto:Chuck.Ries@microsoft.com">Chuck.Ries@microsoft.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I’m a little confused. This patch is for a separate issue; it’s a separate commit. Should it be attached to the review for the other commit?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>]
<br>
<b>Sent:</b> Tuesday, March 10, 2015 4:53 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD8238%2Bpublic%2Bd4d2ef3693b3ed2b@reviews.llvm.org" target="_blank">reviews+D8238+public+d4d2ef3693b3ed2b@reviews.llvm.org</a>; Chuck Ries; <a href="mailto:abidh.haq@gmail.com" target="_blank">abidh.haq@gmail.com</a><br>
<b>Cc:</b> <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [Lldb-commits] [PATCH] expose 64 bit breakpoint addresses through MI<u></u><u></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi Chuck, can you resubmit this patch attached to the other review? The workflow isn't entirely obvious, but there's a couple of things you need to do different.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">1) When you create the diff with the suggested changes, create the diff against origin (or whatever you created the *original* patch against), not against the first version of the patch. So if HEAD is the first version of the patch you
uploaded, create your diff against HEAD~1. You want the new patch to contain the changes _plus_ the original patch.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">2) When you attach the patch to Phabricator, you'll get a combo box and the default value is "Create new revision". Change this to "Attach to existing revision" and then choose the entry for the first patch you uploaded.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Tue, Mar 10, 2015 at 4:49 PM Chuck Ries <<a href="mailto:chuckr@microsoft.com" target="_blank">chuckr@microsoft.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi abidh,<br>
<br>
<a href="http://reviews.llvm.org/D8238" target="_blank">http://reviews.llvm.org/D8238</a><br>
<br>
Files:<br>
tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
<br>
Index: tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
===================================================================<br>
--- tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
+++ tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp<br>
@@ -1048,7 +1048,7 @@<br>
bool<br>
CMICmnLLDBDebugSessionInfo::MIResponseFormBrkPtFrameInfo(const SBrkPtInfo &vrBrkPtInfo, CMICmnMIValueTuple &vwrMiValueTuple)<br>
{<br>
- const CMIUtilString strAddr(CMIUtilString::Format("0x%08llx", vrBrkPtInfo.m_pc));<br>
+ const CMIUtilString strAddr(CMIUtilString::Format("0x%016llx", vrBrkPtInfo.m_pc));<br>
const CMICmnMIValueConst miValueConst2(strAddr);<br>
const CMICmnMIValueResult miValueResult2("addr", miValueConst2);<br>
if (!vwrMiValueTuple.Add(miValueResult2))<br>
Index: tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
===================================================================<br>
--- tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
+++ tools/lldb-mi/MICmnLLDBDebugSessionInfo.h<br>
@@ -87,7 +87,7 @@<br>
CMIUtilString m_strType; // Break point type.<br>
bool m_bDisp; // True = "del", false = "keep".<br>
bool m_bEnabled; // True = enabled, false = disabled break point.<br>
- MIuint m_pc; // Address number.<br>
+ MIuint64 m_pc; // Address number.<br>
CMIUtilString m_fnName; // Function name.<br>
CMIUtilString m_fileName; // File name text.<br>
CMIUtilString m_path; // Full file name and path text.<br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">
http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div></div></blockquote></div>