[Lldb-commits] [Diffusion] rL231449: Provide synthetic children for some vector types

[Ilia K]

Hello Enrico,

I already have fixed it. Please, check r231490.

Thanks,
Ilia

On Fri, Mar 6, 2015 at 10:40 PM, Enrico Granata <egranata at apple.com> wrote:

> This revision should fix it:
>
> Sending        source/DataFormatters/FormatManager.cpp
> Sending        source/DataFormatters/VectorType.cpp
> Sending        source/Symbol/ClangASTType.cpp
> Sending
> test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py
> Sending        test/functionalities/data-formatter/rdar-10642615/main.cpp
> Transmitting file data .....
> Committed revision 231504.
>
> Thanks for keeping an eye on tests!
>
> On Mar 6, 2015, at 3:13 AM, Ilia K <ki.stfu at gmail.com> wrote:
>
> It broke the following tests:
>
>  ======================================================================
>  FAIL: test_with_dsym_and_run_command
> (Test-rdar-10642615.Radar10642615DataFormatterTestCase)
>     Test data formatter commands.
>  ----------------------------------------------------------------------
>  Traceback (most recent call last):
>    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 456, in
> wrapper
>      return func(self, *args, **kwargs)
>    File
> "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py",
> line 21, in test_with_dsym_and_run_command
>      self.data_formatter_commands()
>    File
> "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py",
> line 68, in data_formatter_commands
>      '(vBool32) valueBool32 = (0, 1, 0, 1)'])
>    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2100, in
> expect
>      msg if msg else EXP_MSG(str, exe))
>  AssertionError: False is not True : '(vUInt8) valueU8 = ('\x01', '\0',
> '\x04', '\0', '\0', '\x01', '\0', '\x04', '\0', '\0', '\0', '\0', '\0',
> '\0', '\0', '\0')' returns expected result
>  Config=x86_64-clang
>  ======================================================================
>  FAIL: test_with_dwarf_and_run_command
> (Test-rdar-10642615.Radar10642615DataFormatterTestCase)
>     Test data formatter commands.
>  ----------------------------------------------------------------------
>  Traceback (most recent call last):
>    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 473, in
> wrapper
>      return func(self, *args, **kwargs)
>    File
> "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py",
> line 28, in test_with_dwarf_and_run_command
>      self.data_formatter_commands()
>    File
> "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py",
> line 68, in data_formatter_commands
>      '(vBool32) valueBool32 = (0, 1, 0, 1)'])
>    File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2100, in
> expect
>      msg if msg else EXP_MSG(str, exe))
>  AssertionError: False is not True : '(vUInt8) valueU8 = ('\x01', '\0',
> '\x04', '\0', '\0', '\x01', '\0', '\x04', '\0', '\0', '\0', '\0', '\0',
> '\0', '\0', '\0')' returns expected result
>  Config=x86_64-clang
>  ----------------------------------------------------------------------
>
> Here is the patch that fixes it: http://reviews.llvm.org/D8102
>
>
> http://reviews.llvm.org/rL231449
>
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>
>
> Thanks,
> *- Enrico*
> [image: 📩] egranata@.com ☎️ 27683
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150306/2e390ceb/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: emoji_u1f4e9.png
Type: image/png
Size: 1028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150306/2e390ceb/attachment.png>