<div dir="ltr">Hello Enrico,<div><br></div><div>I already have fixed it. Please, check r231490.</div><div><br></div><div>Thanks,</div><div>Ilia</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 6, 2015 at 10:40 PM, Enrico Granata <span dir="ltr"><<a href="mailto:egranata@apple.com" target="_blank">egranata@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">This revision should fix it:<div><br></div><div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Sending source/DataFormatters/FormatManager.cpp</div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Sending source/DataFormatters/VectorType.cpp</div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Sending source/Symbol/ClangASTType.cpp</div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Sending test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py</div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Sending test/functionalities/data-formatter/rdar-10642615/main.cpp</div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Transmitting file data .....</div><div style="margin:0px;font-size:16px;font-family:'Perfect DOS VGA 437';color:rgb(41,249,20);background-color:rgb(0,0,0)">Committed revision 231504.</div></div><div><br></div><div>Thanks for keeping an eye on tests!</div><div><br><div><blockquote type="cite"><div><div class="h5"><div>On Mar 6, 2015, at 3:13 AM, Ilia K <<a href="mailto:ki.stfu@gmail.com" target="_blank">ki.stfu@gmail.com</a>> wrote:</div><br></div></div><div><div><div class="h5">It broke the following tests:<br><br> ======================================================================<br> FAIL: test_with_dsym_and_run_command (Test-rdar-10642615.Radar10642615DataFormatterTestCase)<br> Test data formatter commands.<br> ----------------------------------------------------------------------<br> Traceback (most recent call last):<br> File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 456, in wrapper<br> return func(self, *args, **kwargs)<br> File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py", line 21, in test_with_dsym_and_run_command<br> self.data_formatter_commands()<br> File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py", line 68, in data_formatter_commands<br> '(vBool32) valueBool32 = (0, 1, 0, 1)'])<br> File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2100, in expect<br> msg if msg else EXP_MSG(str, exe))<br> AssertionError: False is not True : '(vUInt8) valueU8 = ('\x01', '\0', '\x04', '\0', '\0', '\x01', '\0', '\x04', '\0', '\0', '\0', '\0', '\0', '\0', '\0', '\0')' returns expected result<br> Config=x86_64-clang<br> ======================================================================<br> FAIL: test_with_dwarf_and_run_command (Test-rdar-10642615.Radar10642615DataFormatterTestCase)<br> Test data formatter commands.<br> ----------------------------------------------------------------------<br> Traceback (most recent call last):<br> File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 473, in wrapper<br> return func(self, *args, **kwargs)<br> File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py", line 28, in test_with_dwarf_and_run_command<br> self.data_formatter_commands()<br> File "/Users/IliaK/p/llvm/tools/lldb/test/functionalities/data-formatter/rdar-10642615/Test-rdar-10642615.py", line 68, in data_formatter_commands<br> '(vBool32) valueBool32 = (0, 1, 0, 1)'])<br> File "/Users/IliaK/p/llvm/tools/lldb/test/lldbtest.py", line 2100, in expect<br> msg if msg else EXP_MSG(str, exe))<br> AssertionError: False is not True : '(vUInt8) valueU8 = ('\x01', '\0', '\x04', '\0', '\0', '\x01', '\0', '\x04', '\0', '\0', '\0', '\0', '\0', '\0', '\0', '\0')' returns expected result<br> Config=x86_64-clang<br> ----------------------------------------------------------------------<br><br>Here is the patch that fixes it: <a href="http://reviews.llvm.org/D8102" target="_blank">http://reviews.llvm.org/D8102</a><br><br><br><a href="http://reviews.llvm.org/rL231449" target="_blank">http://reviews.llvm.org/rL231449</a><br><br>EMAIL PREFERENCES<br> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br><br><br><br></div></div>_______________________________________________<br>lldb-commits mailing list<br><a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div>Thanks,</div><div><i>- Enrico</i><br><img goomoji="1f4e9" style="margin:0 0.2ex;vertical-align:middle;max-height:24px" alt="📩" src="cid:1f4e9@goomoji.gmail"> egranata@<font color="#ff2600"></font>.com ☎️ 27683</div><div><br></div></div></div></div></div></div><br><br>
</div>
<br></div></div></blockquote></div><br></div>