[Lldb-commits] [PATCH] Python Split [2/2] - Content change

[Zachary Turner]

There is one more issue which I was unable to solve, which is that
ScriptInterpreter::Initialize() calls
ScriptInterpreterPython::Initialize().  So anyone linking against
liblldb-core.a needs to pull in the python stuff too, which isn't always
possible.  This works fine in the CMake build, but I wasn't able to figure
out how to make it work in the Xcode build.  I could get argdumper to
build, but not lldb-server.  If I tried to have lldb-server depend on the
python stuff under API\Bindings\Python, then I got errors about not being
able to find SB classes, I guess because of something to do with framework?

On Thu, Mar 5, 2015 at 2:46 PM Greg Clayton <clayborg at gmail.com> wrote:

> ProcessGDBRemote::ParsePythonTargetDefinition() will also need to be
> updated to use StructuredData objects and the conversion from Python to
> StructuredData objects will need to be done in ScriptInterpreterPython.
>
> So:
>
>   lldb::ScriptInterpreterObjectSP target_definition_sp (interpreter->
> GetDynamicSettings(module_object_sp,
>
>               &GetTarget(),
>
>               "gdb-server-target-definition",
>
>               error));
>
>   PythonDictionary target_dict(target_definition_sp);
>
> Will need to become:
>
>   lldb::StructuredDataObjectSP target_definition_sp (interpreter->
> GetDynamicSettings(module_object_sp,
>
>               &GetTarget(),
>
>               "gdb-server-target-definition",
>
>               error));
>
>   StructuredData::Dictionary *dict = target_definition_sp->
> GetAsDictionary();
>   if (dict)
>   {
>   }
>
> So Python* data types should _only_ exist in ScriptInterpreterPython code
> and should always be converted to StructuredData types before being given
> out to any code within LLDB.
>
>
> http://reviews.llvm.org/D7957
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150305/fbe8e1b9/attachment.html>