[Lldb-commits] [PATCH] Python Split [2/2] - Content change

[Greg Clayton]

ProcessGDBRemote::ParsePythonTargetDefinition() will also need to be updated to use StructuredData objects and the conversion from Python to StructuredData objects will need to be done in ScriptInterpreterPython.

So:

  lldb::ScriptInterpreterObjectSP target_definition_sp (interpreter->GetDynamicSettings(module_object_sp,
                                                                                        &GetTarget(),
                                                                                        "gdb-server-target-definition",
                                                                                        error));
  
  PythonDictionary target_dict(target_definition_sp);

Will need to become:

  lldb::StructuredDataObjectSP target_definition_sp (interpreter->GetDynamicSettings(module_object_sp,
                                                                                        &GetTarget(),
                                                                                        "gdb-server-target-definition",
                                                                                        error));
  
  StructuredData::Dictionary *dict = target_definition_sp->GetAsDictionary();
  if (dict)
  {
  }

So Python* data types should _only_ exist in ScriptInterpreterPython code and should always be converted to StructuredData types before being given out to any code within LLDB.


http://reviews.llvm.org/D7957

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/