[Lldb-commits] [PATCH] Reduce header footprint of Module.h
zturner at google.com
Tue Mar 3 10:45:40 PST 2015
Yea I don't plan to impl entire classes. If I end up with any patches that
I'm unsure about, I'll upload them for you to look at first.
On Tue, Mar 3, 2015 at 10:44 AM Greg Clayton <clayborg at gmail.com> wrote:
> This is fine as long as you don't take a simple class that contains very
> few things (like ClangASTType) and try to hide everything behind a
> unique_ptr just to avoid clang includes. I don't want to trade of compile
> time for run time performance (heap fragmentation).
> Your fix in this patch was fine as it moved a ClangASTContext into a
> shared pointer which is fine as it is a large class.
> > On Mar 3, 2015, at 10:37 AM, Zachary Turner <zturner at google.com> wrote:
> > Thanks, I'll take this as a sign that it's ok to commit further patches
> of this nature. Let me know if you have concerns about any of the patches
> I submit. Removing header file includes from other headers breaks some cpp
> files, so I'll make sure to test on all 3 platforms before comitting
> > REPOSITORY
> > rL LLVM
> > http://reviews.llvm.org/D8022
> > EMAIL PREFERENCES
> > http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits