[Lldb-commits] [PATCH] Reduce header footprint of Module.h

[Greg Clayton]

This is fine as long as you don't take a simple class that contains very few things (like ClangASTType) and try to hide everything behind a unique_ptr just to avoid clang includes. I don't want to trade of compile time for run time performance (heap fragmentation).

Your fix in this patch was fine as it moved a ClangASTContext into a shared pointer which is fine as it is a large class.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8022

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/