[Lldb-commits] [PATCH] Fix execution of platform shell commands on android

[Pavel Labath]

REPOSITORY
  rL LLVM

================
Comment at: include/lldb/Host/android/HostInfoAndroid.h:26
@@ -25,3 +22,4 @@
-    ~HostInfoAndroid();
+  public:
+    static FileSpec GetDefaultShell();
 
   protected:
----------------
tberghammer wrote:
> labath wrote:
> > How is the constructor removal related to the rest of the patch?
> It is absolutely unrelated just I noticed that construction is already disabled in the bottom most base class (HostInfoBase) and non of the derived have explicit code for doing it, so made it consistent.
> Can revert this part if you want.
Sounds like I good thing to do. Keep them removed.

================
Comment at: source/Host/android/ProcessLauncherAndroid.cpp:42
@@ +41,3 @@
+    const static char* path = "PATH=";
+    const static int path_len = strlen(path);
+    for (const char** args = env.GetConstArgumentVector(); *args; ++args)
----------------
labath wrote:
> Storage specifiers (static) are usually placed before the type (including the "const" keyword).
This should be read "please put static before const". :)

http://reviews.llvm.org/D8009

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/