[Lldb-commits] [PATCH] Fix execution of platform shell commands on android

Tamas Berghammer tberghammer at google.com
Mon Mar 2 11:17:00 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: include/lldb/Host/android/HostInfoAndroid.h:26
@@ -25,3 +22,4 @@
-    ~HostInfoAndroid();
+  public:
+    static FileSpec GetDefaultShell();
 
   protected:
----------------
labath wrote:
> How is the constructor removal related to the rest of the patch?
It is absolutely unrelated just I noticed that construction is already disabled in the bottom most base class (HostInfoBase) and non of the derived have explicit code for doing it, so made it consistent.
Can revert this part if you want.

http://reviews.llvm.org/D8009

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list