[Lldb-commits] [PATCH] Move argument globbing to Target::Launch from Platform::LaunchProcess.
zturner at google.com
Thu Feb 19 17:09:10 PST 2015
On Thu Feb 19 2015 at 5:01:43 PM Enrico Granata <egranata at apple.com> wrote:
> On Feb 19, 2015, at 4:55 PM, Zachary Turner <zturner at google.com> wrote:
> The reason I didn't bring this up earlier is because Windows actually can
> glob with *. so the examples i had seen so far would have worked. If we
> want to say that you get arbitrary shell expansion, then that's going to
> make tests very hard to write portably, and I'm not crazy about the idea of
> seeing even more platform specific tests going in.
> So instead, why not just agree on a very simple subset of what the shell
> does -- in particular allow the use of the character set [*.?] and just
> write the glob function ourselves?
> I just don’t see the value of doing more work for less feature.
I see it as more work now for all the feature you actually need, and less
> PlatformWindows could very well decide that it does not support globbing
>> if this is such a big deal.
> It does though, just with a different set of rules. So now any test that
> goes in to test this has to have tests for each platform's shell syntax.
> We should be trying to find abstractions to bring all the platforms
> together IMO, not increasing the separation.
> That which will be part of testing the platform-specific bits of your
There's inherent value in having as few platform specific bits as
possible. When the same rules apply to every platform,
a) everyone gets better test coverage
b) everyone gets to benefit from everyone else's changes and bugfixes
c) as a user, it makes it easier and more comfortable to switch platforms
since you don't have to do a mental switch.
d) It makes the code easier to maintain
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits