[Lldb-commits] [PATCH] Skip lldb-mi tests on FreeBSD for now
vharron at google.com
Wed Feb 18 11:01:28 PST 2015
We need as many tests as possible. I think that the lldb-mi tests are
incredibly valuable. Thanks to the lldb-mi team for that!
Looking over the Linux builders, I'm noticing that the lldb-mi tests are
changing state frequently. I think that Ed should submit this change for
now. I'd also like him to disable the tests on Linux for now.
I would like the LLDB MI guys to followup quickly with a patch that enables
tests that they know are 100% reliable and quickly XFAIL as necessary.
I know the buildbots aren't green but we're actually closing on that.
On Wed, Feb 18, 2015 at 10:12 AM, Zachary Turner <zturner at google.com> wrote:
> Fwiw I don't feel strongly either way. Right now it seems there's issues
> with lldb-mi such that even disabling them individually now, a new test
> that gets added might have the same issue, because the issue is not in the
> implementation of a particular test or feature, but of the larger lldb-mi
> library. So this would still lead to the possibility that any future test
> may also have to be disabled, creating more work than necessary.
> Of course, the correct way to deal with this is to prioritize finding and
> fixing the underlying race conditions. Presumably they affect not just
> On Wed, Feb 18, 2015 at 10:05 AM Ilia K <ki.stfu at gmail.com> wrote:
>> In http://reviews.llvm.org/D7727#125642, @emaste wrote:
>> > In http://reviews.llvm.org/D7727#125628, @ki.stfu wrote:
>> > > If it works unstable on FreeBSD you should skip it and later we can
>> re-enable test on FreeBSD when it will be fixed. I don't see a reason to
>> modify dotest.py file.
>> > I think it's better to make this change here than add 43 decorators
>> across 12 lldb-mi test files
>> It's 'sad' that lldb-mi has grown to such an extent, but the designed @
>> skipIfFreeBSD is better than a hack in dotest.py.
>> EMAIL PREFERENCES
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
Vince Harron | Technical Lead Manager | vharron at google.com | 858-442-0868
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits