<div dir="ltr"><div>Hi all,</div><div><br></div><div>We need as many tests as possible. I think that the lldb-mi tests are incredibly valuable. Thanks to the lldb-mi team for that!</div><div><br></div><div>Looking over the Linux builders, I'm noticing that the lldb-mi tests are changing state frequently. I think that Ed should submit this change for now. I'd also like him to disable the tests on Linux for now.<br></div><div><br></div><div>I would like the LLDB MI guys to followup quickly with a patch that enables tests that they know are 100% reliable and quickly XFAIL as necessary.<br></div><div><br></div><div>I know the buildbots aren't green but we're actually closing on that.</div><div><br></div><div>Thoughts?</div><div><br></div><div>Vince</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 18, 2015 at 10:12 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Fwiw I don't feel strongly either way. Right now it seems there's issues with lldb-mi such that even disabling them individually now, a new test that gets added might have the same issue, because the issue is not in the implementation of a particular test or feature, but of the larger lldb-mi library. So this would still lead to the possibility that any future test may also have to be disabled, creating more work than necessary.<br><br>Of course, the correct way to deal with this is to prioritize finding and fixing the underlying race conditions. Presumably they affect not just FreeBSD. <br><div class="HOEnZb"><div class="h5"><div class="gmail_quote">On Wed, Feb 18, 2015 at 10:05 AM Ilia K <<a href="mailto:ki.stfu@gmail.com" target="_blank">ki.stfu@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">In <a href="http://reviews.llvm.org/D7727#125642" target="_blank">http://reviews.llvm.org/D7727#<u></u>125642</a>, @emaste wrote:<br>
<br>
> In <a href="http://reviews.llvm.org/D7727#125628" target="_blank">http://reviews.llvm.org/D7727#<u></u>125628</a>, @ki.stfu wrote:<br>
><br>
> > If it works unstable on FreeBSD you should skip it and later we can re-enable test on FreeBSD when it will be fixed. I don't see a reason to modify dotest.py file.<br>
><br>
><br>
> I think it's better to make this change here than add 43 decorators across 12 lldb-mi test files<br>
<br>
<br>
It's 'sad' that lldb-mi has grown to such an extent, but the designed @ skipIfFreeBSD is better than a hack in dotest.py.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D7727" target="_blank">http://reviews.llvm.org/D7727</a><br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
<br>
<br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
lldb-commits mailing list<br>
<a href="mailto:lldb-commits@cs.uiuc.edu">lldb-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><br><table cellspacing="0" cellpadding="0" style="font-family:'Times New Roman'"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Vince Harron |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Technical Lead Manager |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:vharron@google.com" target="_blank">vharron@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 858-442-0868</td></tr></tbody></table><br></div></div>
</div>