[Lldb-commits] [lldb] r229085 - Fix the last two warnings I see on Linx building 'lldb': mismatched

Chandler Carruth chandlerc at gmail.com
Fri Feb 13 00:16:16 PST 2015


Author: chandlerc
Date: Fri Feb 13 02:16:15 2015
New Revision: 229085

URL: http://llvm.org/viewvc/llvm-project?rev=229085&view=rev
Log:
Fix the last two warnings I see on Linx building 'lldb': mismatched
signed and unsigned types in comparisons.

For the text offset, use the addr_t type that is used elsewhere to get
these kinds of offsets, and which it is being compared against. This
seems to make things more consistent.

For the other, the numbers are clearly small and uninteresting, so just
cast them to the most boring 'int' type.

Modified:
    lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp

Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp?rev=229085&r1=229084&r2=229085&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp (original)
+++ lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp Fri Feb 13 02:16:15 2015
@@ -615,7 +615,7 @@ AssemblyParse_x86::get_non_call_site_unw
 {
     UnwindPlan::RowSP row(new UnwindPlan::Row);
     m_cur_insn = m_func_bounds.GetBaseAddress ();
-    int current_func_text_offset = 0;
+    addr_t current_func_text_offset = 0;
     int current_sp_bytes_offset_from_cfa = 0;
     UnwindPlan::Row::RegisterLocation initial_regloc;
     Error error;
@@ -746,7 +746,7 @@ AssemblyParse_x86::get_non_call_site_unw
                 saved_registers[machine_regno] = false;
                 row->RemoveRegisterInfo (lldb_regno);
 
-                if (machine_regno == m_machine_fp_regnum)
+                if (machine_regno == (int)m_machine_fp_regnum)
                 {
                     row->SetCFARegister (m_lldb_sp_regnum);
                 }





More information about the lldb-commits mailing list