[Lldb-commits] [PATCH] Fix the variable printing for stack-list-local and stack-list-arguments.

[Hafiz Abid Qadeer]

Hi ki.stfu,

Fix for http://llvm.org/bugs/show_bug.cgi?id=21744

GetVariableInfo () collected the values of the variable in a list. But it also
tried to generate the name/value pairs for children. This caused generation of
a wrong value string for may items. This function has been fixed to put value in
the list only.

The handling of --print-value related option has been moved to caller.

GetVariableInfo2 and MIResponseFormVariableInfo3 have been removed. They were
almost the duplicate of functions of similar names. I dont see any difference in
the output of -stack-list-locals and -stack-list-arguments. So these functions
just seemed unnecessary.

Char variable was being printed as a string which caused garbage output. This has
been fixed.

Some misc. cleanup.

Test cases have been added that check -stack-list-locals for struct, array and
pointers. Modified other tests which depended on hard coded line numbers. 

TODO: Those hardcoded line numbers should be removed.

http://reviews.llvm.org/D7589

Files:
  test/tools/lldb-mi/Makefile
  test/tools/lldb-mi/TestMiExec.py
  test/tools/lldb-mi/TestMiStack.py
  test/tools/lldb-mi/locals.c
  test/tools/lldb-mi/main.c
  tools/lldb-mi/MICmdCmdStack.cpp
  tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp
  tools/lldb-mi/MICmnLLDBDebugSessionInfo.h
  tools/lldb-mi/MICmnLLDBUtilSBValue.cpp
  tools/lldb-mi/MICmnMIValueList.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7589.19829.patch
Type: text/x-patch
Size: 38677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150212/5c5f407b/attachment.bin>