[Lldb-commits] [lldb] r228908 - Quiet Coverity

[Justin Hibbits]

Author: jhibbits
Date: Wed Feb 11 23:31:31 2015
New Revision: 228908

URL: http://llvm.org/viewvc/llvm-project?rev=228908&view=rev
Log:
Quiet Coverity

Summary: Coverity warns that unsigned >= 0 is always true, and k_first_gpr_powerpc happens to be 0.  Quiet Coverity by changing that comparison instead to a static_assert(), in case things change in the future.

Reviewers: emaste

Reviewed By: emaste

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D7576

Modified:
    lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp

Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp?rev=228908&r1=228907&r2=228908&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp Wed Feb 11 23:31:31 2015
@@ -159,9 +159,10 @@ g_reg_sets_powerpc[k_num_register_sets]
     { "Altivec/VMX Registers",  "vmx", k_num_vmx_registers_powerpc, g_vmx_regnums },
 };
 
+static_assert(k_first_gpr_powerpc == 0, "GPRs must index starting at 0, or fix IsGPR()");
 bool RegisterContextPOSIX_powerpc::IsGPR(unsigned reg)
 {
-    return (reg >= k_first_gpr_powerpc) && (reg <= k_last_gpr_powerpc);   // GPR's come first.
+    return (reg <= k_last_gpr_powerpc);   // GPR's come first.
 }
 
 bool