[Lldb-commits] [PATCH] Add -exec-arguments command

[Greg Clayton]

> On Feb 11, 2015, at 2:24 PM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> In http://reviews.llvm.org/D6965#121476, @clayborg wrote:
> 
>> It would be nice to have lldb_private::Target have its own ProcessLaunchInfo as a member variable and change all storage of settings (target.run-args, target.arg0 etc) and have the settings just modify the lldb_private::Target's version of this.
> 
> 
> I'll try do it but how I can synchronize Target::m_GlobalLaunchInfo and Debugger's property (which can be set by "settings set" command)?

target.run-args is a target based property. If you have no targets yet, it will set them in a  global instance, when you have a target, it will set it on the current target.

There should be no: m_GlobalLaunchInfo

It should be m_launch_info;

And it should live in TargetProperties.

> I can't update m_GlobalLaunchInfo every time when "settings set target.run-args" is executed. Therefore will be 2 different places where these arguments are stored.

No, this is wrong. 
> 
> As I said, currently "settings set" stores all values as debugger's properties. And I don't want to do the following:

that is incorrect, it sets the values in TargetProperties. There is a global version when no targets exist, and when a target does exist and it is the currently selected target, then that target's TargetProperties will get modified correctly.

> 
>  if (property == "target.run-args") {
>      Target::GetGlobalLaunchInfo().SetRunArguments(value);
>  }
>  else {
>      Debugger.SetProperty(...);
>  }
> 

You won't have do to the above code.

> http://reviews.llvm.org/D6965
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
>