[Lldb-commits] [PATCH] Fix argdumper build in cmake (OS X) after r228636

[Enrico Granata]

Well we do tell you "could not find tool" so it is a sane failure mode

One could argue for, if you can't find the tool just keep going, but given that you explicitly asked for globbing, I think that would be counter-intuitive. And also, the tool should really be there!

Thanks for digging into this!

Sent from my iPhone

> On Feb 10, 2015, at 10:48 PM, Ilia K <ki.stfu at gmail.com> wrote:
> 
> Hello Enrico,
> 
>> RE: I assume that the lack of this build logic was causing the test case to fail on your machine. Correct?
> 
> 
> Correct. But tests had failed on my side because argdumper not found. I use cmake to build lldb.
> 
> Log:
> 
>  1: test_with_dsym (TestLaunchWithGlob.LaunchWithGlobTestCase) ...
>  os command: make clean ; make MAKE_DSYM=YES ARCH=x86_64 CC="clang"
>  with pid: 94168
>  stdout: rm -f "a.out"  main.o main.d main.d.tmp
>  rm -f -r "a.out.dSYM"
>  clang++ -std=c++11 -g -O0 -arch x86_64   -I/Users/IliaK/p/llvm/tools/lldb/test/make/../../include   -c -o main.o main.cpp
>  clang++  main.o -g -O0 -arch x86_64   -I/Users/IliaK/p/llvm/tools/lldb/test/make/../../include   -o "a.out"
>  "/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil"  -o "a.out.dSYM" "a.out"
> 
>  stderr:
>  retcode: 0
> 
> 
>  runCmd: file /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob/a.out
>  output: Current executable set to '/Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob/a.out' (x86_64).
> 
> 
>  /Users/IliaK/p/llvm/build_ninja/lib/python2.7/site-packages/lldb
>  runCmd: process launch -G true -w /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob -- fi*.tx?
>  runCmd failed!
>  error: could not find argdumper tool
> 
> 
>  Command 'process launch -G true -w /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob -- fi*.tx?' failed!
> 
>  /Users/IliaK/p/llvm/build_ninja/lib/python2.7/site-packages/lldb
>  runCmd: process launch -G true -w /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob -- fi*.tx?
>  runCmd failed!
>  error: could not find argdumper tool
> 
> 
>  Command 'process launch -G true -w /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob -- fi*.tx?' failed!
> 
>  /Users/IliaK/p/llvm/build_ninja/lib/python2.7/site-packages/lldb
>  runCmd: process launch -G true -w /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob -- fi*.tx?
>  runCmd failed!
>  error: could not find argdumper tool
> 
> 
>  Command 'process launch -G true -w /Users/IliaK/p/llvm/tools/lldb/test/functionalities/launch_with_glob -- fi*.tx?' failed!
> 
>  FAILURE
> 
> 
> http://reviews.llvm.org/D7550
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits